Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many Filters Skip The Last Pixel - Tested with PNGs #119

Open
Pandaphobic opened this issue Mar 8, 2022 · 4 comments
Open

Many Filters Skip The Last Pixel - Tested with PNGs #119

Pandaphobic opened this issue Mar 8, 2022 · 4 comments
Assignees

Comments

@Pandaphobic
Copy link

When I apply any of the affects below to an image (png in my case), the very last pixel in the bottom right corner is omitted and staus unchanged.

  • neue
  • solarize
  • lix
  • dramatic
  • firenze
  • obsidian
  • sepia
  • grayscale (single channel alterantives work fine)
  • desaturate

It seems that any filter that has this line will fail to affect the last pixel
let end = img.get_raw_pixels().len() - 4;

Be sure to view images in a pixel friendly viewer - many image viewers will make it very blurry

dramatic
firenze
lix
neue
obsidian
sepia
solarize

@Pandaphobic Pandaphobic changed the title Filters skip last pixel in PNG Many Filters Skip The Last Pixel - Tested with PNGs Mar 8, 2022
@silvia-odwyer
Copy link
Owner

silvia-odwyer commented Mar 9, 2022

@Pandaphobic Hi Chris, thanks very much for opening this issue! I'll be sure to investigate this and work on a fix as soon as possible. ✅

Thanks again! 😄

@silvia-odwyer silvia-odwyer self-assigned this Mar 9, 2022
@Pandaphobic
Copy link
Author

Curious if you ever found anything on this! I've tried to figure it out a few times but no luck yet

@silvia-odwyer
Copy link
Owner

@Pandaphobic Hi Chris! I've just fixed this bug in the filters mentioned, the last pixel should have the filter/effect applied to it now.

The repository has been updated with the fix, and I'll be publishing a new version of the crate soon also ✅ Thanks very much for letting me know about this, it's much appreciated! 👍 😄

@Pandaphobic
Copy link
Author

@silvia-odwyer Thanks so much for taking a look at this! For some reason, this actually broke my app so I'm going to have to look over my implementation. The images it makes now are very odd so I must be mishandling something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants