Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to return after converting #135

Closed
arggh opened this issue Sep 19, 2019 · 5 comments
Closed

Add option to return after converting #135

arggh opened this issue Sep 19, 2019 · 5 comments

Comments

@arggh
Copy link

arggh commented Sep 19, 2019

Would be nice, if one could go back to the trim & settings view after the conversion completes. Even better, if one could preview the end result before actually clicking Convert and saving the gif.

Use case:

After converting the video to gif, user notices that a) filesize is too large b) resolution wasn't quite the correct choice after all c) framerate drop was too obvious.

Now it would be very handy to keep other settings, including trimming which the user spent a lot of time to get just right, and change only the one setting that required tweaking.


Somewhat related: #97

@sindresorhus
Copy link
Owner

Duplicate of #112

@sindresorhus sindresorhus marked this as a duplicate of #112 Sep 19, 2019
@sindresorhus
Copy link
Owner

if one could preview the end result before actually clicking Convert and saving the gif.

You mean preview the GIF? There's no way to show the GIF without actually first converting it. You don't have to save the GIF to preview it though. Just press Space after the conversion is done to quick look the GIF.

After converting the video to gif, user notices that a) filesize is too large

We're working on improving the file size estimate, so that should hopefully be less of a problem going forward: #129

@arggh
Copy link
Author

arggh commented Sep 19, 2019

You mean preview the GIF?

Yes, that was the idea. I think previewing the gif in the same screen where I tweak the conversion settings is a superior user experience compared to going back and forth between the settings-view and the save-view. Especially, since there is already a video player present in the settings-view.

For example, there could be a button Render preview or a toggle: Original - Preview

If you select Preview, the original video would be replaced with the gif and a progress indicator, that would let me know whenever gifski is busy converting a new preview. Tweaking the settings would start the preview conversion from scratch.

This would make it effortless to tweak the quality and framerate settings.

Another idea to speed up the preview process: how about rendering just the first frame of the gif with the settings applied? That should be plenty fast, and you would get some perspective into what the final result will look like, given the resolution and quality. Maybe even let the user scrub-select frames and render them as needed?

Just an idea.

@sindresorhus
Copy link
Owner

@arggh I like your idea. I think we should explore it further. Could you copy-paste your above comment into a new issue focused on the GIF preview idea?

@arggh
Copy link
Author

arggh commented Sep 19, 2019

New issue at #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants