Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make menu bar color adapt to wallpaper #121

Open
novyboy opened this issue Jan 27, 2023 · 2 comments
Open

Make menu bar color adapt to wallpaper #121

novyboy opened this issue Jan 27, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@novyboy
Copy link

novyboy commented Jan 27, 2023

Is your feature request related to a problem? Please describe.

Currently, even when a website with a background is overlaid on top of the desktop with Plash, the menu bar continues to color itself based on the vanilla desktop wallpaper.

Describe the solution you'd like

Add an option that enables you to choose to set menu bar color:

  • Dynamically, based on the contents of the web page beneath it (the vanilla menu bar behavior), or
  • Based on the background-color of the body tag or the theme-color meta tag if specified and not transparent, or
  • Not at all

Describe alternatives you've considered

  • Add an input to set menu bar color by choosing with a color picker or by inputing a hex code
  • Cache the current vanilla wallpaper and update the wallpaper to a color, gradient, or background decided using the solution, alternate solution above, or some other solution, then reset it to the cached wallpaper on exit

Additional context

The way iWallpaper selects menu bar color is a possible reference for how to do this

@novyboy novyboy added the enhancement New feature or request label Jan 27, 2023
@sindresorhus
Copy link
Owner

@sindresorhus sindresorhus closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2023
@sindresorhus
Copy link
Owner

iWallpaper works by both setting the actual wallpaper to a static image taken from the video it presents. Plash could potentially do this, but it's not easy as Plash has many more factors to consider. Plash supports transparency and it does not know when the background actually changes (a website could change it dynamically), so Plash would have to constantly poll or risk being outdated.

I guess there could be an opt-in setting for this, but it's not something I plan to work on.

@sindresorhus sindresorhus reopened this Jan 27, 2023
@sindresorhus sindresorhus changed the title Change Menu Bar Color Make menu bar color adapt to wallpaper Jan 27, 2023
@sindresorhus sindresorhus added the help wanted Extra attention is needed label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants