Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new disable shortcut hook is great, I'd like a similar "pause/unpause" shortcut #154

Open
StashPowerUser opened this issue Jan 24, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@StashPowerUser
Copy link

I use a website for plash that play video playlists as a background

The shortcut to disable/re-enable is great, but it causes my playlist position to be lost as plash does not save the current URL and always reloads to the website's home page.

I'd like a pause shortcut action that hides the plash background and pauses the renderer, and corresponding unpause that does the opposite.

Alternately, if plash could save/restore the current url when disabling/enabling that would be almost as good.

@StashPowerUser StashPowerUser added the enhancement New feature or request label Jan 24, 2024
@sindresorhus
Copy link
Owner

Alternately, if plash could save/restore the current url when disabling/enabling that would be almost as good.

👍 I think it should do that.


// @Lilfaen in case you're interested in working on this.

@sindresorhus sindresorhus added the help wanted Extra attention is needed label Jan 24, 2024
@StashPowerUser
Copy link
Author

The save/restore of current URL would also be useful more generally for sleep/wake, shutdown and startup

@Lilfaen
Copy link
Contributor

Lilfaen commented Apr 12, 2024

@sindresorhus
When trying to get the current url using WebsitesController.shared.current I always get the initial url.
In the Xcode logs, I get a warning: Failed to encode domain (null), 1 (0) every time the url changes, like in a video playlist.
Could you look into that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants