Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and create an helper to get deployments addresses #46

Open
2 tasks
dhadrien opened this issue Dec 3, 2022 · 12 comments
Open
2 tasks

Fix and create an helper to get deployments addresses #46

dhadrien opened this issue Dec 3, 2022 · 12 comments
Assignees

Comments

@dhadrien
Copy link
Member

dhadrien commented Dec 3, 2022

https://github.com/sismo-core/sismo-protocol/blob/accountbound-improvements-and-airdrop-attester/tasks/deploy-tasks/full/0-deploy-core-and-hydra-s1-simple-and-accountbound.task.ts#L266

Issue with

   -> proxy: ${(await hre.deployments.all()).Front.address}
  • fix: add deployment prefix like this one:
(await hre.deployments.all())[options.deploymentNamePrefix + '_Front'].address
  • clean: create helper to be reused
@Pontipilat777
Copy link

👍

@marmeladnaaV
Copy link

I thonk you should refactor the code

@Fedotff
Copy link

Fedotff commented Jan 21, 2023

👍

@terrabass
Copy link

terrabass commented Jan 22, 2023 via email

@TobianMads5
Copy link

👍

3 similar comments
@Z1GuR
Copy link

Z1GuR commented Jan 25, 2023

👍

@LexLuter1
Copy link

👍

@DikonKol77
Copy link

👍

@RealeLR
Copy link

RealeLR commented Jan 28, 2023

Good job

@VikMezz
Copy link

VikMezz commented Feb 1, 2023

Class

@Z1GuR
Copy link

Z1GuR commented Feb 26, 2023

cool

@dafnorka
Copy link

great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests