Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web application highlights wrong editor element when clicking the preview #174

Open
Big-Cnut opened this issue Jun 16, 2022 · 3 comments
Open

Comments

@Big-Cnut
Copy link

When an element is clicked in the preview of the nomnoml web application, a wrong element is highlighted in the editor.
Which element gets highlighted depends on the web browser's zoom factor.

Reproducibility:

  1. Set web browser (Firefox) zoom factor to 0 ([CTRL][0]),
  2. In the example graph, click [beard] --> [singing] is highlighted in the editor.

PS: Many thanks for nomnoml - a great App!

@skanaar
Copy link
Owner

skanaar commented Jun 16, 2022

Hi, thank you for those nice words!

Actually there is no highlighting of the source code when clicking in the graph. The text editor is transparent and you are selecting that line.

@Big-Cnut
Copy link
Author

Thanks for your answer.
LOL - well, I admit I was so confident that this is a cool nomnoml feature, that this explanation didn't even come to my mind!
So maybe you can take this as an improvement proposal: when graphs become larger, it is difficult to find the relation between the graph and editor elements. So highlighting and scrolling to the right position when selecting an element either in the editor or in the graph would be very useful!

@skanaar
Copy link
Owner

skanaar commented Jun 17, 2022

There have been some work dealing with clickable nodes actually, in a SVG context.
Not a bad idea integrating that into the nomnoml webapp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants