Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups not functioning without sigh_mixin #1145

Open
jdswebb opened this issue May 18, 2024 · 1 comment
Open

Groups not functioning without sigh_mixin #1145

jdswebb opened this issue May 18, 2024 · 1 comment
Assignees
Labels
question open question solved available upstream or in a branch

Comments

@jdswebb
Copy link

jdswebb commented May 18, 2024

I've been trying to experiment with not using signals, but found when not using sigh_mixin groups stop working. I'm not sure if this is a bug or intentional, but to reproduce take the example:

https://github.com/skypjack/entt/blob/master/test/example/signal_less.cpp

And add the line: auto grp = registry.group<int>();

Observe failure to compile due to group_handler implementation assuming on_construct exists.

Thanks

@skypjack skypjack self-assigned this May 21, 2024
@skypjack skypjack added the question open question label May 21, 2024
@skypjack
Copy link
Owner

Indeed, they don't. Confirmed. They were designed on top of the signal mechanism initially and I never changed it.
In theory, we can redesign them as a mixin today and avoid using signals. However, it's not super high prio at the moment.

@skypjack skypjack added the solved available upstream or in a branch label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question open question solved available upstream or in a branch
Projects
None yet
Development

No branches or pull requests

2 participants