Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support key filter api #304

Open
takkuumi opened this issue Jan 11, 2023 · 3 comments
Open

Feature: Support key filter api #304

takkuumi opened this issue Jan 11, 2023 · 3 comments
Labels
C-enhancement New feature or request

Comments

@takkuumi
Copy link

Description

There is an lskey action, but it must to declare a size for lskey action. if skytable support an api like filterkey, i think it's very useful.

In fact, in the process of retrieving the key, I first call lskey, give it a large enough value, and then filter the results. If we built it into the action, then we can easily retrieve and filter the key.

@takkuumi takkuumi added the C-enhancement New feature or request label Jan 11, 2023
@ohsayan
Copy link
Member

ohsayan commented Jan 11, 2023

While a filtering API would be trivial to write, the time complexity of the function would be O(n) (n=size of dataset). In your use case, would such a performance penalty be acceptable?

In other cases, indexing would be the solution (but again scaling indexes in a distributed environment is another challenge; but that's something we're working on)

@takkuumi
Copy link
Author

@ohsayan Agree with your point. However, the actual situation is different. In my usage scenario, the KEY collection is not too large, and index or full scan filtering is acceptable in performance observation.

@ohsayan
Copy link
Member

ohsayan commented Apr 1, 2023

Makes sense. Let's target the 0.8.1 tag for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants