Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leveled compaction crashes when recovering from manifest #62

Open
YangchenYe323 opened this issue Mar 16, 2024 · 1 comment · May be fixed by #63
Open

Leveled compaction crashes when recovering from manifest #62

YangchenYe323 opened this issue Mar 16, 2024 · 1 comment · May be fixed by #63

Comments

@YangchenYe323
Copy link
Contributor

The LeveledCompactionController::apply_compaction_result method tries to sort the merged SSTs by key inside the method, which will cause problem when this method is called in manifest recovery context, because at that point no actual SSTs are loaded.
@YangchenYe323 YangchenYe323 linked a pull request Mar 16, 2024 that will close this issue
Open
@TheLudlows
Copy link

There is indeed a problem with this, sorting can be extracted from apply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Avoid leveled compaction crash when recovering from manifest YangchenYe323/mini-lsm
2 participants
@TheLudlows @YangchenYe323