Should function signatures be consistent between mini-lsm-starter and mini-lsm?

[Gleiphir2769]

Hi, I noticed that some function signatures is different beween mini-lsm-starter and mini-lsm.

For example, decode_block_meta in mini-lsm-starter

mini-lsm/mini-lsm-starter/src/table.rs

Lines 45 to 47 in bcaab6f

	/// Decode block meta from a buffer.
	pub fn decode_block_meta(buf: impl Buf) -> Vec<BlockMeta> {
	unimplemented!()

decode_block_meta in mini-lsm

mini-lsm/mini-lsm/src/table.rs

Lines 64 to 66 in bcaab6f

	pub fn decode_block_meta(mut buf: &[u8]) -> Result<Vec<BlockMeta>> {
	let mut block_meta = Vec::new();
	let num = buf.get_u32() as usize;

According to the commit history, it seems that decode_block_meta in mini-lsm was later modified, causing the function signature to change. I found many similar situations while reading the code.

Does it need to be fixed? If it is, let me know and I can help to fix them.

[skyzh]

&[u8] implements Buf and I believe the interface is fully compatible. Both ways should work.