Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyboard shortcuts should work inside the window panes too #216

Open
swyxio opened this issue Aug 29, 2023 · 1 comment
Open

keyboard shortcuts should work inside the window panes too #216

swyxio opened this issue Aug 29, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@swyxio
Copy link
Contributor

swyxio commented Aug 29, 2023

generally we want the cmd+1/2/3 and the cmd +/- to also work when focused in on one pane, rather than only when the superprompt is focused.
@swyxio swyxio added the bug Something isn't working label Aug 29, 2023
@swyxio swyxio assigned seanoliver and unassigned seanoliver Aug 29, 2023
@swyxio swyxio added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 29, 2023
@swyxio swyxio pinned this issue Aug 30, 2023
@swyxio
Copy link
Contributor Author

swyxio commented Sep 6, 2023

looked at this today, but have to inject a bunch of keydown/keyup listeners into each window that is capable of calling back into the top level react code (see function onKeyDown in layout.tsx... we basically have to inject that into each window and i have no idea how to do it yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanoliver @swyxio