Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createScriptLoader's onLoad fails from time to time with FF #601

Open
jchatard opened this issue Apr 3, 2024 · 0 comments
Open

createScriptLoader's onLoad fails from time to time with FF #601

jchatard opened this issue Apr 3, 2024 · 0 comments

Comments

@jchatard
Copy link

jchatard commented Apr 3, 2024

Describe the bug

In Firefox-based browsers, the onload callback of createScriptLoader is not fired systematically.

It works perfectly in Chrome, but it fails in Firefox.

I've set up a reproduction using Cypress, which allows testing the behavior in different browsers.

Instructions are in the README.

Minimal Reproduction Link

https://github.com/jchatard/script-loader-ff
jchatard added a commit to jchatard/solid-primitives that referenced this issue Apr 4, 2024
@jchatard
Fix script loading issue in Firefox fixes solidjs-community#601
9e98a7b 
In Firefox the onload attribute is not always triggered on script element so we instead use script.addEventListener('load')
@atk atk mentioned this issue May 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jchatard