Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate frontend translations from solidus_core to solidus_starter_frontend #5212

Open
rainerdema opened this issue Jul 3, 2023 · 0 comments

Comments

@rainerdema
Copy link
Contributor

Desired Behavior

All translations used by the starter frontend reside in solidus_core: This creates challenges during the development of the starter, as each time a translation key needs to be added, a dedicated PR in solidus is required.

Moreover, it's not consistent to have these translations in the core: They should be part of the frontend, which will then be copied into the host after installation, allowing the possibility to make changes if needed.

The plan is to conduct this transition in different stages across both repositories and:

  1. Move all the deprecated translations in core to a separate locale files (e.g. solidus/core/config/locales/en.deprecated.yml).
  2. Copy the file to the host application as part of the solidus installation/upgrade process.
  3. In the next major release, remove the deprecated file from solidus_core and relocate it to solidus_starter_frontend.

For more details, see this conversation: solidusio/solidus_starter_frontend#348 (comment)

Current Behavior

Currently, any addition or change to translations requires a new pull request in solidus, as all translation keys used by the starter frontend are located in solidus_core.

Additional notes

Consider this specific key, which hasn't been added to solidus_core to avoid the needless inclusion of another key that would subsequently need to be removed: #5208
This key will be among those directly inserted into the solidus_starter_frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant