New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and remove "dashboards" code #4860

Open

jarednorman opened this issue Jan 17, 2023 · 7 comments · May be fixed by #5448

Labels

good first issue

Member

jarednorman commented Jan 17, 2023

None of this provides any real value. Adding a custom dashboard is trivial and I really don't think we need a custom permission set and empty controller/view.

Member Author

jarednorman commented Jan 17, 2023

This could be replaced with a default admin location.

Contributor

forkata commented Jan 17, 2023

I doubt anyone is using this, but I guess we would have to deprecate and then remove this in a major version?

Member Author

jarednorman commented Jan 18, 2023

Yeah, that's my thought. It was introduced alongside the permission sets, but I've never seen a store that used it.

kennyadsl added the good first issue label

lauriejefferson commented Oct 6, 2023

I would like to work on this issue. Is it still open?

Member Author

jarednorman commented Oct 6, 2023

The new admin renders this kind of moot, but it couldn't hurt to still do this.

lauriejefferson commented Oct 11, 2023 •

edited

@jarednorman Do you want to add deprecation warnings in the files listed above or just remove them?

Member Author

jarednorman commented Oct 12, 2023

I think they should be deprecated first.

lauriejefferson linked a pull request

that will close this issue

4860-deprecate-and-remove-dashboards-code #5448

Open

nvandoorn pushed a commit to nvandoorn/solidus that referenced this issue


          Deprecate and remove dashboard code

7d1942f

As stated by @jarednorman (in solidusio#4860):
> None of this provides any real value. Adding a custom dashboard is
> trivial and I really don't think we need a custom permission set and
> empty controller/view.

This was referenced Feb 13, 2024

Deprecate and remove dashboard code #5661

Closed

Deprecate and remove dashboard code nvandoorn/solidus#1

Merged

nvandoorn pushed a commit to nvandoorn/solidus that referenced this issue


          Deprecate and remove dashboard code

a6310a1

As stated by @jarednorman (in solidusio#4860):
> None of this provides any real value. Adding a custom dashboard is
> trivial and I really don't think we need a custom permission set and
> empty controller/view.

nvandoorn pushed a commit to nvandoorn/solidus that referenced this issue


          Deprecate and remove dashboard code

066a5c9

As stated by @jarednorman (in solidusio#4860):
> None of this provides any real value. Adding a custom dashboard is
> trivial and I really don't think we need a custom permission set and
> empty controller/view.

nvandoorn pushed a commit to nvandoorn/solidus that referenced this issue


          Deprecate and remove dashboard code

31e7c19

As stated by @jarednorman (in solidusio#4860):
> None of this provides any real value. Adding a custom dashboard is
> trivial and I really don't think we need a custom permission set and
> empty controller/view.

nvandoorn pushed a commit to nvandoorn/solidus that referenced this issue


          Deprecate and remove dashboard code

2218aaf

As stated by @jarednorman (in solidusio#4860):
> None of this provides any real value. Adding a custom dashboard is
> trivial and I really don't think we need a custom permission set and
> empty controller/view.

nvandoorn pushed a commit to nvandoorn/solidus that referenced this issue


          Deprecate and remove dashboard code

As stated by jarednorman (in solidusio#4860):
> None of this provides any real value. Adding a custom dashboard is
> trivial and I really don't think we need a custom permission set and
> empty controller/view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment