Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin][UI][Bulk actions] Require confirmation before completing bulk deletes #5740

Open
forkata opened this issue May 2, 2024 · 2 comments

Comments

@forkata
Copy link
Contributor

forkata commented May 2, 2024

Currently, bulk deleting resources such as products happens without confirmation. This is not ideal, so we want to introduce a manual confirmation step.

There's no specific design for this, but we can reference what we have for deleting a product with a different copy such as

Remove 3 products?
This can't be undone.

Image

@forkata
Copy link
Contributor Author

forkata commented May 2, 2024

The first part of this is done, which is adding the ability to confirm a batch action. I think we may want this to be the default behaviour for all batch actions?

The second part is implementing the modal instead of the default browser confirm dialog.

@forkata
Copy link
Contributor Author

forkata commented May 2, 2024

First part of this change was merged here #5702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

1 participant