Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam search too slow on the transducer-conformer recipe #2301

Open
asumagic opened this issue Dec 14, 2023 · 1 comment
Open

Beam search too slow on the transducer-conformer recipe #2301

asumagic opened this issue Dec 14, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@asumagic
Copy link
Collaborator

Describe the bug

Evaluating LibriSpeech test-clean can take >1h instead of something like two minutes.

I am not sure if this affects other models. Greedy search is much faster in comparison.

We've already brought this up internally a few times but I realized we didn't have a formal issue to link to for it, so here it is.

Expected behaviour

It should not take as long. Unsure where exactly the fault lies (TransducerBeamSearch or simply the parameters?), I didn't diagnose this much yet. Profiling did not show anything peculiar other than that evaluating the LSTM took roughly a third~half of that time and that there was a high number of iterations.

To Reproduce

The following recipe is affected during evaluation: https://github.com/speechbrain/speechbrain/tree/develop/recipes/LibriSpeech/ASR/transducer

If required I can try to provide a python script repro.

Environment Details

No response

Relevant Log Output

No response

Additional Context

No response

@asumagic asumagic added the bug Something isn't working label Dec 14, 2023
@TParcollet
Copy link
Collaborator

TParcollet commented Jan 30, 2024

It's not slow ... it is slow AS FUCK. But I believe that this is expected from python only RNN6T decoders.

@Adel-Moumen Adel-Moumen self-assigned this Feb 25, 2024
@Adel-Moumen Adel-Moumen added this to the v1.0.1 milestone Apr 8, 2024
@Adel-Moumen Adel-Moumen modified the milestones: v1.0.1, v1.0.2 May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants