Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase to 8.6.7. Fixes: Fix disabled tests in speedb_db_bloom_filter_test.cc #767

Open
udi-speedb opened this issue Nov 14, 2023 · 0 comments

Comments

@udi-speedb
Copy link
Contributor

As part of the rebase on RocksDB 8.6.7, the following commit:
39f5846 - Much better stats for seeks and prefix filtering (#11460)

Included changes that cause speedb_db_bloom_filter_test.cc to fail some tests.

speedb_db_bloom_filter_test.cc was essentially a duplicate of db_bloom_filter_test.cc with focus on paired bloom filter.

It might be worth doing away with speedb_db_bloom_filter_test.cc altogether, and integrating the paired bloom filter tests in the existing db_bloom_filter_test.cc. This will avoid the duplication of a lot of existing testing code and also solve most of the problems. The reason for not doing so in the first place were to keep the paired bloom filter as an external plug in. However, this seems not to make sense considering the current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant