Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_bench: fresh db benchmark might increase thread pools sizes #784

Open
Yuval-Ariel opened this issue Dec 19, 2023 · 0 comments
Open

db_bench: fresh db benchmark might increase thread pools sizes #784

Yuval-Ariel opened this issue Dec 19, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Yuval-Ariel
Copy link
Contributor

When running a benchmark without the use_existing_db flag, the db is first destroyed with the default options without considering the flags supplied. here:

 if (!FLAGS_use_existing_db) {
      Options options;
      options.env = FLAGS_env;
      if (!FLAGS_wal_dir.empty()) {
        options.wal_dir = FLAGS_wal_dir;
      }
      if (use_blob_db_) {
        // Stacked BlobDB
        blob_db::DestroyBlobDB(FLAGS_db, options, blob_db::BlobDBOptions());
      }
      DestroyDB(FLAGS_db, options);

this might cause SanitizeOptions to call
result.env->IncBackgroundThreadsIfNeeded(bg_job_limits.max_compactions, Env::Priority::LOW);
result.env->IncBackgroundThreadsIfNeeded(bg_job_limits.max_flushes, Env::Priority::HIGH);
with the default options for these flags and not the ones supplied in db bench.
the test then doesnt shrink back these thread pools.

@Yuval-Ariel Yuval-Ariel added the bug Something isn't working label Dec 19, 2023
@Yuval-Ariel Yuval-Ariel self-assigned this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant