Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the extras field #41

Open
DethRaid opened this issue Jan 3, 2024 · 1 comment
Open

Support the extras field #41

DethRaid opened this issue Jan 3, 2024 · 1 comment
Labels
done Everything has been addressed enhancement New feature or request

Comments

@DethRaid
Copy link
Contributor

DethRaid commented Jan 3, 2024

I'd like to request support for the extras field in fastgltf. I don't need anything fancy, a simple string will suffice

I know there's been some discussion about this on Discord, but this feature is crucial to what I'm trying to do so I'm making an Issue about it

@spnda spnda added the enhancement New feature or request label Jan 30, 2024
@spnda
Copy link
Owner

spnda commented Feb 21, 2024

A first revision of this functionality has been implemented with 01b5990. This, however, does not support some cases:

  • Primitive extras
  • Sparse accessor extras

Also, I'm afraid that perhaps letting the user access the simdjson objects directly might cause some issues. There perhaps also should be some sort of possibility of reporting errors on the callback function, especially when encountering JSON parsing issues. I'll still leave this issue open because of the two unsupported edge cases, possible improvements to the API, and its relation to #5, but still mark this as 'done'.

@spnda spnda added the done Everything has been addressed label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Everything has been addressed enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants