Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify product properties error #11893

Open
babyfire opened this issue May 24, 2023 · 2 comments
Open

Modify product properties error #11893

babyfire opened this issue May 24, 2023 · 2 comments

Comments

@babyfire
Copy link

Context

When modifying product properties, a blank property will be added automatically.

Expected Behavior

Do not automatically add product properties,add it manually instead.

Steps to Reproduce

edit

Your Environment

  • Version used:
    spree (= 4.5.3)
    spree_auth_devise (= 4.5.0)
    spree_backend (= 4.5.1)
    spree_emails (= 4.5.3)
    spree_frontend (= 4.5.0)
    spree_gateway (= 3.10.0)
    spree_i18n (= 5.2.0)
    spree_sample (= 4.5.3)
@masoud-arabi
Copy link

Hi, Is this issue still open? I am new to open source and I would like to contribute to this issue.

@rafalcymerys
Copy link
Member

@masoud-arabi yes, it's still open. Actually I think we could just remove the frontend validation for that field - if it's empty it won't add a new property anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants