You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a commit that seemed to address this issue in 2020, but I can find no evidence that the option unless is implemented in the checkout module. fe90925
Actual Behavior
Confirm step is skipped after delivery step.
Expected Behavior
I would like to see the confirm page before order is complete.
Reproduction Steps
In order decorator override confirmation_required? to always return true
def confirmation_required?
true
end
Create a promotion for free shipping & 100% off of an order
Create a cart with anything in it and add the 100% off promotion
Continue through checkout until order is complete
The text was updated successfully, but these errors were encountered:
Context
There is a line in the order class which is supposed to remove the transitions between delivery and confirm contingently on the order confirmation_required? predicate. In practice this line always removes the transition (obvious anytime the payment step is not presented i.e. a $0 order).
https://github.com/spree/spree/blob/af13aaac04754ee37faef0d0121a4938f5c68b63/core/app/models/spree/order.rb#LL74C6-L74C7
There is a commit that seemed to address this issue in 2020, but I can find no evidence that the option
unless
is implemented in the checkout module. fe90925Actual Behavior
Confirm step is skipped after delivery step.
Expected Behavior
I would like to see the confirm page before order is complete.
Reproduction Steps
confirmation_required?
to always return trueThe text was updated successfully, but these errors were encountered: