-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's not clear what some actions in the new Options menus of Variable Explorer editors do #21824
Comments
@jitseniesen, @CAM-Gerlach, what do you think about this one? |
Before the PR, this was a button with a tooltip with the text "Set format of floating-point numbers". The PR moved this to a menu item and an unintended consequence was that the tooltip disappeared, because menus do not show tooltips by default. So one solution may be to turn on We can change the name of the menu item, but I think that your proposed name is too long. Maybe The text in the dialog itself should certainly be clarified.
I think I understood this option only by reading the code. The option The best description I can come up with is "Assign colours by column", but I don't think that is very clear either. This requires a fuller explanation elsewhere, either in a tooltip or in our documentation. We can also consider removing that option. I can imagine situations where it could be useful but I'm not sure how much it is actually used, and it is hard to find out what it does. |
I like this suggestion because it works better for a menu entry (I know mine was too long).
Yeah, that seems hard to explain with the action text alone. We could also say
Since tooltips in menus are not an expected UI element, that's perhaps not an option. And improving our docs is a good idea but the interface should be easy enough to grasp on its own.
Yeah, that's another option but I wouldn't like to remove current functionality because I'm sure some users rely on it and wouldn't be happy about it. |
A more radical idea is not to have the options (hamburger) menu, but instead have a toolbutton like 🔧 . That button opens up a dialog with a text field for the format string for floating point numbers and two checkbuttons, one for turning on/off the background colour and one for the column min/max option. The advantage is that we can use a bit more text in a dialog window and we can also add tooltips. However, this is quite a big thing to do before 6.0. |
This is a very good idea! @CAM-Gerlach, what do you think?
I could give you a hand with it after we release beta1. |
I think the col min/max applies the background color independently for each Series: Or across the entire DataFrame: The subtle difference can be seen in the DataFrame above. It might be better to have a dropdown box with something like: background color applied via: ['Series', 'DataFrame'] background color by: ['Series', 'DataFrame'] Or if the checkbox option is preferred renaming "column min/max" to "color by Series" may be easier to read. Using DataFrame and Series in this context is more consistent to pandas documentation and therefore should be clear to someone working with pandas.
|
Here is a (non-functional) mock-up of what a dialog window can look like. I put the new toolbar button to the left of the refresh button, where the button for setting the format used to be. My main doubt is whether I should combine the two groups ("Background color" and "Coloring algorithm") in one group with three options. If this looks promising, then I can implement the functionality and submit a PR so that we can start fine tuning the text and the graphics layout. What do you think? dataframe-prefs.mp4 |
This looks really nice, thanks @jitseniesen! My only suggestion is to leave the current Options menu and add this as an action called That way we would maintain consistency with the other editors and we could also add a |
Format
, which we could rename toSet format for floating point numbers
(or something like that). Furthermore, we could add a descriptive text to the dialog that opens after clicking on it with a link to the format syntax that users can set there.Column min/max
. Just by reading that text, I don't understand what it does. And I tried to enable/disable it in a simple dataframe and I didn't see any difference.The text was updated successfully, but these errors were encountered: