Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement associative arrays for bash services #23

Open
Marak opened this issue Jan 17, 2017 · 1 comment
Open

Implement associative arrays for bash services #23

Marak opened this issue Jan 17, 2017 · 1 comment
Labels
enhancement

Comments

@Marak
Copy link
Collaborator

Marak commented Jan 17, 2017

Right now, bash services are still injecting all request and env parameters into separate unique bash variables ( like how Lua use to work prior to #18 )

It would be better if we used bash 4 feature of associative arrays for creating two objects, Hook.params and Hook.env, which are populated with many items ( instead of creating many unique variable names )
@Marak
Copy link
Collaborator Author

Marak commented Feb 10, 2017

I added the code, but it turns out bash 4 isn't readily installed on many systems.

I'll see if I can get this checked in with dual support for bash 3 and 4.

Marak added a commit that referenced this issue Oct 17, 2017
@Marak
[bash] Basic support for associative arrays #23
8219082 
  * Now using associative arrays for bash params
  * Requires bash 4
  * Could use more work with env / hook object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Marak