Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor spawn plugin into separate module #29

Open
Marak opened this issue Feb 12, 2017 · 0 comments
Open

Refactor spawn plugin into separate module #29

Marak opened this issue Feb 12, 2017 · 0 comments

Comments

@Marak
Copy link
Collaborator

Marak commented Feb 12, 2017

The core spawning logic at https://github.com/Stackvana/microcule/blob/master/lib/plugins/spawn/index.js currently has two concerns coupled together: preparing the service options for spawning, and managing the spawned service.

microcule's spawning logic should only be concerned with preparing the service options. The actual spawning and managing of STDIO communications should be handled in a separate module.

To start, we can separate these concerns into separate files within this project. If it makes sense to then move the spawn logic itself to a separate package, we will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant