Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Assistant: Wrong URL to HA instance skill shown #197

Open
spacegaier opened this issue May 11, 2021 · 4 comments
Open

Home Assistant: Wrong URL to HA instance skill shown #197

spacegaier opened this issue May 11, 2021 · 4 comments
Labels
P2 We need to fix it (backlog)

Comments

@spacegaier
Copy link
Contributor

After successful integration of Almond and HA, this is listed in the "My Skills" panel:

grafik

The location "http://supervisor/homeassistant" however is wrong. Looks like a dev placeholder 馃槃.

@spacegaier spacegaier changed the title Home Assistant: Wrong URL to HA instance shown Home Assistant: Wrong URL to HA instance skill shown May 11, 2021
@gcampax
Copy link
Contributor

gcampax commented May 18, 2021

The location is correct, in fact. That's the URL used by add-ons to connect to Home Assistant from inside the docker contaienr network. We should probably hide it though if it is confusing.

@spacegaier
Copy link
Contributor Author

In the coding I see a different one: https://github.com/stanford-oval/thingpedia-common-devices/blob/cbe9efec3d43bb6abc911684abacb35064d5dc30/main/io.home-assistant/index.js#L25

But this one seems to win: https://github.com/stanford-oval/almond-hassio-repository/blob/514458df1bfd7835d176dfce182e408b64ec2e5e/edge/rootfs/etc/services.d/almond/register#L30

Ideally it should dynamically be determined (current host + default HA port 8123) and in then long run be configurable as the coding comment already states 馃槣.

@gcampax
Copy link
Contributor

gcampax commented May 20, 2021

Again, in the code the location is correct - as you noted, the one in the addon wins. There is a DNS configuration in the supervisor that makes those URLs work. This is only a matter of displaying the right URL - which would need to come from Home Assistant's external URL then.

@spacegaier
Copy link
Contributor Author

Yes, I understand that technically this URL is correct for the internal workings, but it's confusing for the end user (since it won't resolve outside of the internal docker containers).

We are on the same page here 馃憤.

@nrser nrser added the P2 We need to fix it (backlog) label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We need to fix it (backlog)
Projects
None yet
Development

No branches or pull requests

3 participants