Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Custom Locales not working #4841

Closed
KleinerSource opened this issue May 15, 2024 · 5 comments · May be fixed by #4893
Closed

[Bug Report] Custom Locales not working #4841

KleinerSource opened this issue May 15, 2024 · 5 comments · May be fixed by #4893
Labels
bug report Bug reports that are not yet verified

Comments

@KleinerSource
Copy link

Describe the bug
Custom Locales not working

To Reproduce
Steps to reproduce the behavior:
interface- Custom localization - Custom localization enabled - enable

Expected behavior
A clear and concise description of what you expected to happen.
add custom locales content to Custom localization
reload pages

Screenshots

image

Stash Version: (from Settings -> About):
v0.25.1
Build hash:
bf7cb78

Build time:
2024-03-13 03:30:08

Desktop (please complete the following information):

  • OS: [e.g. Win11]
  • Browser [e.g. chrome, edge]
@KleinerSource KleinerSource added the bug report Bug reports that are not yet verified label May 15, 2024
@QxxxGit
Copy link

QxxxGit commented May 15, 2024

From my testing:

{
    "performer": "Tester",
    "performers": "Testers"
}

I can see instances of Performers (plural) changing (nav bar, scene filters) but the singular Performer would not change in the scene filters or scene page etc.

@WithoutPants
Copy link
Collaborator

From my testing:

{
"performer": "Tester",
"performers": "Testers"
}
I can see instances of Performers (plural) changing (nav bar, scene filters) but the singular Performer would not change in the scene filters or scene page etc.

Scene page uses countables.performers which explains why you didn't see the change there.

@KleinerSource can you please attach the custom localization string you used in your settings? I think the most likely culprit is that the JSON is malformed. You can check for this yourself by opening the browser dev tools and looking at the console output.

@KleinerSource
Copy link
Author

image
image

NO json error

@WithoutPants
Copy link
Collaborator

SyntaxError: Expected ',' or '}' after property value in JSON at position 16730 (line 471 column 7)

This is an error in your custom localisation string.

@KleinerSource
Copy link
Author

I have adjusted the JSON and resolved the issue. Thank you for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants