Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add C implementations to base special math functions (tracking issue) #649

Open
kgryte opened this issue Dec 2, 2022 · 8 comments
Open

[RFC]: Add C implementations to base special math functions (tracking issue) #649

kgryte opened this issue Dec 2, 2022 · 8 comments
Labels
Accepted RFC feature request which has been accepted. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tracking Issue Tracking issue.

Comments

@kgryte
Copy link
Member

kgryte commented Dec 2, 2022 •
edited

Description

This RFC proposes adding C implementations to all base special math functions. The purpose of this issue is to serve as a tracking issue for adding C implementations.

Packages

  • abs
  • abs2
  • abs2f
  • absf
  • acos
  • acosd
  • acosh
  • acot
  • acotd
  • acoth
  • acovercos
  • acoversin
  • acsc
  • acscd
  • acsch
  • ahavercos
  • ahaversin
  • asec
  • asecd
  • asech
  • asin
  • asind
  • asinf
  • asinh
  • atan
  • atan2
  • atand
  • atanh
  • avercos
  • aversin
  • bernoulli
  • besselj0
  • besselj1
  • bessely0
  • bessely1
  • beta
  • betainc
  • betaincinv
  • betaln
  • binet
  • binomcoef
  • binomcoefln
  • boxcox
  • boxcox1p
  • boxcox1pinv
  • boxcoxinv
  • cabs
  • cabs2
  • cabs2f
  • cabsf
  • cbrt
  • cbrtf
  • cceil
  • cceilf
  • cceiln
  • ccis
  • ceil
  • ceil10
  • ceil2
  • ceilb
  • ceilf
  • ceiln
  • ceilsd
  • cexp
  • cflipsign
  • cflipsignf
  • cfloor
  • cfloorn
  • cidentity
  • cidentityf
  • cinv
  • clamp
  • clampf
  • copysign
  • copysignf
  • cos
  • cosd
  • cosh
  • cosm1
  • cospi
  • cot
  • cotd
  • coth
  • covercos
  • coversin
  • cphase
  • cpolar
  • cround
  • croundn
  • csc
  • cscd
  • csch
  • csignum
  • deg2rad
  • deg2radf
  • digamma
  • dirac-delta
  • dirichlet-eta
  • docs
  • ellipe
  • ellipj
  • ellipk
  • erf
  • erfc
  • erfcinv
  • erfcx
  • erfinv
  • examples
  • exp
  • exp10
  • exp2
  • expit
  • expm1
  • expm1rel
  • factorial
  • factorial2
  • factorialln
  • falling-factorial
  • fast
  • fibonacci
  • fibonacci-index
  • flipsign
  • flipsignf
  • floor
  • floor10
  • floor2
  • floorb
  • floorf
  • floorn
  • floorsd
  • fresnel
  • fresnelc
  • fresnels
  • frexp
  • gamma
  • gamma-delta-ratio
  • gamma-lanczos-sum
  • gamma-lanczos-sum-expg-scaled
  • gamma1pm1
  • gammainc
  • gammaincinv
  • gammaln
  • gammasgn
  • gcd
  • hacovercos
  • hacoversin
  • havercos
  • haversin
  • heaviside
  • hypot
  • hypotf
  • identity
  • identityf
  • inv
  • invf
  • kernel-betainc
  • kernel-betaincinv
  • kernel-cos
  • kernel-sin
  • kernel-tan
  • kronecker-delta
  • kronecker-deltaf
  • labs
  • lcm
  • ldexp
  • lib
  • ln
  • log
  • log10
  • log1mexp
  • log1p
  • log1pexp
  • log1pmx
  • log2
  • logaddexp
  • logit
  • lucas
  • max
  • maxabs
  • maxabsn
  • maxn
  • min
  • minabs
  • minabsn
  • minmax
  • minmaxabs
  • minmaxabsn
  • minmaxn
  • minn
  • modf
  • negafibonacci
  • negalucas
  • nonfibonacci
  • pdiff
  • pdifff
  • polygamma
  • pow
  • powm1
  • rad2deg
  • ramp
  • rampf
  • rcbrt
  • rempio2
  • riemann-zeta
  • rising-factorial
  • round
  • round10
  • round2
  • roundb
  • roundn
  • roundsd
  • rsqrt
  • rsqrtf
  • secd
  • sici
  • signum
  • signumf
  • sin
  • sinc
  • sincos
  • sincospi
  • sinh
  • sinpi
  • spence
  • sqrt
  • sqrt1pm1
  • sqrtf
  • sqrtpi
  • tan
  • tand
  • tanh
  • test
  • tribonacci
  • trigamma
  • trunc
  • trunc10
  • trunc2
  • truncb
  • truncf
  • truncn
  • truncsd
  • vercos
  • versin
  • wrap
  • xlog1py
  • xlogy

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Enhancement Issue or pull request for enhancing existing functionality. and removed Feature Issue or pull request for adding a new feature. labels Dec 2, 2022
This was referenced Jan 30, 2024
Open
Open
@kgryte kgryte added difficulty: 3 Likely to be challenging but manageable. Accepted RFC feature request which has been accepted. priority: High High priority concern or feature request. labels Feb 25, 2024
This was referenced Mar 3, 2024
Closed
Closed
Closed
Closed
@Pratik772846
Copy link
Contributor

@kgryte I would like to work on this.

@Snehil-Shah Snehil-Shah mentioned this issue Mar 5, 2024
Closed
3 tasks
@Pratik772846 Pratik772846 mentioned this issue Mar 5, 2024
Closed
3 tasks
This was referenced Mar 5, 2024
Merged
Closed
Merged
@kgryte
Copy link
Member Author

kgryte commented Mar 6, 2024

@Pratik772846 I suggest picking one of the associated RFCs for updating a single package. This is a tracking issue.

@kgryte
Copy link
Member Author

kgryte commented Mar 6, 2024

@Pranavchiku As you've been managing a number of the RFCs and PRs, would you mind updating the OP to match the current state of implementations?

@kgryte kgryte added the Tracking Issue Tracking issue. label Mar 6, 2024
This was referenced Mar 7, 2024
Closed
Closed
Merged
@tudor-pagu tudor-pagu mentioned this issue Mar 7, 2024
Open
3 tasks
@gunjjoshi gunjjoshi mentioned this issue Mar 7, 2024
Closed
3 tasks
@Rejoan-Sardar Rejoan-Sardar mentioned this issue Mar 7, 2024
Closed
3 tasks
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this issue Mar 20, 2024
@gunjjoshi @kgryte
feat: add C implementation for math/base/special/boxcox
e6df6cc 
PR-URL: 	stdlib-js#1870
Ref: stdlib-js#649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this issue Mar 20, 2024
@Rejoan-Sardar @kgryte @gunjjoshi
feat: add C implementation for math/base/special/boxcoxinv
facf870 
PR-URL: 	stdlib-js#1878
Ref: stdlib-js#649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this issue Mar 20, 2024
@gunjjoshi @Pranavchiku
feat: add C implementation for math/base/special/acotd
3b2c240 
PR-URL: stdlib-js#1879 
Closes: stdlib-js#649

---------

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
kgryte added a commit that referenced this issue Mar 21, 2024
@gunjjoshi @kgryte
feat: add C implementation for math/base/special/gamma-lanczos-sum
5c8ab25 
PR-URL: 	#1834
Closes: #1822
Ref: #649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this issue Mar 21, 2024
@gunjjoshi @Pranavchiku
feat: add C implementation for math/base/special/gammasgn
66318f9 
PR-URL: stdlib-js#1841
Closes: stdlib-js#649

---------

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this issue Mar 21, 2024
@gunjjoshi @kgryte
feat: add C implementation for math/base/special/boxcox
f6c02e0 
PR-URL: 	stdlib-js#1870
Ref: stdlib-js#649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this issue Mar 21, 2024
@Rejoan-Sardar @kgryte @gunjjoshi
feat: add C implementation for math/base/special/boxcoxinv
1a61ba7 
PR-URL: 	stdlib-js#1878
Ref: stdlib-js#649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Rejoan Sardar <119718513+Rejoan-Sardar@users.noreply.github.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this issue Mar 21, 2024
@gunjjoshi @Pranavchiku
feat: add C implementation for math/base/special/acotd
f588998 
PR-URL: stdlib-js#1879 
Closes: stdlib-js#649

---------

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
gunjjoshi added a commit to gunjjoshi/stdlib that referenced this issue Mar 21, 2024
@gunjjoshi @kgryte
feat: add C implementation for math/base/special/gamma-lanczos-sum
94ab2a2 
PR-URL: 	stdlib-js#1834
Closes: stdlib-js#1822
Ref: stdlib-js#649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
@gunjjoshi gunjjoshi mentioned this issue Mar 21, 2024
Merged
1 task
@performant23 performant23 mentioned this issue Mar 22, 2024
Open
3 tasks
kgryte added a commit that referenced this issue Mar 23, 2024
@USERSATOSHI @kgryte
feat: add C implementation of `math/base/special/fast/alpha-max-plus-…
abf4652 
…beta-min`

PR-URL: 	#1947
Closes: #1938
Ref: #649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Mar 23, 2024
@performant23 @kgryte @Pranavchiku
feat: add C implementation for math/base/special/fast/uint32-log2
c17484a 
PR-URL: 	#1946
Closes: #1931 
Ref: #649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in>
Signed-off-by: Rutam <138517416+performant23@users.noreply.github.com>
Signed-off-by: Pranav Goswami <goswami.4@iitj.ac.in>
Signed-off-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Pranav Goswami <goswami.4@iitj.ac.in>
This was referenced Mar 24, 2024
Open
Closed
@Pranavchiku
Copy link
Member

Updated as per latest develop

This was referenced Mar 29, 2024
Open
Open
Open
kgryte added a commit that referenced this issue Apr 20, 2024
@aman-095 @kgryte
feat: add C implementation for math/base/special/gcd
753fbf2 
PR-URL: #1703
Closes: #1701
Ref: #649
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
@kgryte kgryte pinned this issue Apr 20, 2024
@gunjjoshi gunjjoshi mentioned this issue Apr 26, 2024
Open
3 tasks
@gunjjoshi gunjjoshi mentioned this issue May 28, 2024
Merged
1 task
Planeshifter added a commit that referenced this issue May 29, 2024
@gunjjoshi @Planeshifter
feat: add C implementation for math/base/special/fibonacci-index
1ba660a 
PR-URL: #2272
Ref: #649

---------

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
This was referenced May 29, 2024
Merged
Merged
Planeshifter added a commit that referenced this issue May 29, 2024
@gunjjoshi @Pranavchiku @Planeshifter
feat: add C implementation for math/base/special/negafibonacci
1bc3682 
PR-URL: #1813
Closes: #1758 
Ref: #649

---------

Signed-off-by: GUNJ JOSHI <gunjjoshi8372@gmail.com>
Signed-off-by: Pranav Goswami <goswami.4@iitj.ac.in>
Co-authored-by: Pranav Goswami <goswami.4@iitj.ac.in>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> 
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Reviewed-by: Pranav Goswami <goswami.4@iitj.ac.in>
Planeshifter pushed a commit that referenced this issue May 29, 2024
@gunjjoshi
feat: add C implementation for math/base/special/lcm
28e1548 
PR-URL: #2276
Ref: #649 

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter pushed a commit that referenced this issue May 29, 2024
@gunjjoshi
feat: add C implementation for math/base/special/exp2
1414d1a 
PR-URL: #2277
Ref: #649

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
@gunjjoshi gunjjoshi mentioned this issue May 31, 2024
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tracking Issue Tracking issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Planeshifter @kgryte @Pranavchiku @Pratik772846