Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get functions such as "find_plane_at_hit" available outside of the "sl.Camera" object #825

Open
2 tasks done
belliriccardo opened this issue Mar 24, 2022 · 2 comments
Open
2 tasks done

Comments

@belliriccardo
Copy link

Preliminary Checks

  • This issue is not a duplicate. Before opening a new issue, please search existing issues.
  • This issue is not a question, bug report, or anything other than a feature request directly related to this project.

Proposal

I am using the ZED 2i camera and the ROS wrapper node, and I found myself in need to use the "find_plane_at_hit" function, especially in conjunction with rviz feature "publish point", that publishes the 3D point coordinates to the topic "/clicked_point".

Now, I could use the points from the topic published in "/zed2i/zed_node/point_cloud/cloud_registered", but it would be done in python (in my case) and it would be much slower. Also, it's already implemented, and it would save a lot of time.

Fact is, it would be nice to have a way to access all the methods defined inside "sl.Camera" from outside, such as with services or with special topics. It would be tremendously helpful for productivity and/or visualization purposes (eg. within rviz itself).

Use-Case

No response

Anything else?

No response

@Myzhar
Copy link
Member

Myzhar commented Mar 31, 2022

Working on the new feature. Something is coming:

Screenshot from 2022-03-31 18-07-25
Screenshot from 2022-03-31 18-07-15
Screenshot from 2022-03-31 18-07-06

You can test it by checking out the add_plane_detection branch.
You must subscribe to the correct topic in Rviz (see the pictures) for the Marker plugin.

Screenshot from 2022-03-31 20-10-09

The next step is adding a custom message with all the info available in the sl::Plane data structure.

@belliriccardo
Copy link
Author

belliriccardo commented Mar 31, 2022

You're the best! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants