Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input filter with pan and tilt #1066

Open
Friismestemacher opened this issue Apr 26, 2023 · 1 comment
Open

input filter with pan and tilt #1066

Friismestemacher opened this issue Apr 26, 2023 · 1 comment

Comments

@Friismestemacher
Copy link

Hey there, is it possible to enritch the input video effect digital zoom with a function that allows us to also move the image? So that we can actually decide on where to zoom on in the picture, not only to the middle?
Is there a way how I to contribute on these effects?

@steveseguin
Copy link
Owner

There's a digital zoom effects filter and a native zoom option.

I don't have any control over the native zoom option on where to zoom.

As per the digital zoom effect, I could add the option to choose where to zoom in, but I guess the challenge is the user interface. How would it work exactly? How does the user select the point to zoom in? What if that point is near the edge of the video?

The digital zoom logic is currently in lib.js under function digitalZoom(reinit=false) {. It's pretty simple.

For all the effects, I only have a single value, session.effectValue, to control the amount of the selected digital effect. This works for zooming in and out, but wouldn't be enough for vertical/horizonal positioning.

Changes to the effects UI controls would need to be changed for the URL, the guest's controls, and the director's controls, and if it was more fancy than just some x/y sliders, it would be a bit tricky to not interfere with all the other existing video interaction and mouse controls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants