Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Font Resizing not always correct when adding and removing video #1088

Open
mattsmallman opened this issue Aug 10, 2023 · 2 comments
Open

Comments

@mattsmallman
Copy link

When viewing a scene with labels. The label font size is updated when new scenes are added but existing labels aren't always correctly updated. This seems to happen most when adding another participant with cover and square enabled to an existing sole video. I had a little look at the code and the logic looks to be correct but it's just not called consistently.

Before
CleanShot 2023-08-10 at 12 59 20@2x

After - 1 Participant
CleanShot 2023-08-10 at 12 57 28@2x

After - 3 Videos
CleanShot 2023-08-10 at 13 03 36@2x

After - 4 Videos
CleanShot 2023-08-10 at 13 05 31@2x

@steveseguin
Copy link
Owner

Thank you for reporting the issue.

@steveseguin
Copy link
Owner

I think I found the bug, and so I pushed a fix to vdo.ninja/alpha/ for testing; seems to be working now anyways.

I'll push my changes to github shortly after some more practical testing, and later to production.

Thank you for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants