Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron Version #1095

Open
sirinath opened this issue Oct 2, 2023 · 3 comments
Open

Electron Version #1095

sirinath opened this issue Oct 2, 2023 · 3 comments

Comments

@sirinath
Copy link

sirinath commented Oct 2, 2023

Maybe it might be an idea to have a packaged version of this to be used with Electron to avoid any Brower conflict due to the browser version or plugins stalled.

The electron package can have better testing on multiple platforms holding the Chromium version constant and the installed extensions constant.

Why I am asking for this is that there was an instance where the speaker could not get the audio to work when using Chrome on a Mac while I was on Vivaldi on Win 11. This is the video which is now unlisted: https://youtube.com/live/U4ur-OY3U-0

@steveseguin
Copy link
Owner

I offer https://github.com/steveseguin/electroncapture as a supported Electron build for VDO.Ninja, but it's mainly in cases when other browsers fail or you need a special setting/feature.

The EC app doesn't auto-update though, so it shouldn't be used as a general everyday browser, since security patches don't get updated as often as with Chrome. I don't have the time or resources to test, update and support the Electron Capture app as much as needed, so it's really just for backup or edge use cases. In the future, I will try to get it to auto-update and auto-build with all new security patches, but that will not be for a while. (perhaps a couple months after I add auto updating to social stream's upcoming app)

Chrome is what I mainly recommend to users though, as it is heavily test; browsers like Vivaldi I try to technically support as well, but you'll probably have more problems using them since they are not commonly used or tested. Brave, Edge, or Opera are more popular it seem than Vivaldi as well, so perhaps those could be options if privacy is the concern. If Vivaldi becomes too problematic though, I'll put up a warning message recommending users not to use it.

@sirinath
Copy link
Author

sirinath commented Oct 2, 2023

I logged in using Vivaldi on Win 11 as the director only.

The video link was opened and played on Electron Capture App on my Win 11 laptop with the screen and application audio shared though SplitCam from my side.

The user opened the sent link on Chrome on a Mac.

As the director the audio was show as on but audio did not work.

@steveseguin
Copy link
Owner

Thank you.

If I can reproduce, I'll fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants