Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue with Quantity Selector #204

Open
developeryashraj opened this issue Jan 17, 2022 · 0 comments
Open

Accessibility issue with Quantity Selector #204

developeryashraj opened this issue Jan 17, 2022 · 0 comments

Comments

@developeryashraj
Copy link

Bug report

Describe the bug

Need to swap aria-label for add and substract quantity buttons

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Go to https://demo.reactstorefront.io/p/3
  2. Do inspect on quantity buttons
  3. Check the labels are coming wrong currently

Expected behavior

Plus icon should have aria-label as "add one quantity" and Minus icon should have aria-label as "Substract one quantity"

Screenshots

image

System information

  • OS: [e.g. macOS, Windows]
  • Browser (if applies) [e.g. chrome, safari]
  • Version of React Storefront: [e.g. 7.0.2]

Additional context

Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant