Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internals restructure #849

Open
patrick91 opened this issue Apr 13, 2021 · 2 comments
Open

Internals restructure #849

patrick91 opened this issue Apr 13, 2021 · 2 comments
Labels
discussion enhancement New feature or request
Projects
Milestone

Comments

@patrick91
Copy link
Member

patrick91 commented Apr 13, 2021

@BryceBeagle and I had an impromptu chat last Friday about restructuring the internals. Our current structure is a bit messy, and moving forwards we want to

Current structure
Proposed structure

we also have miro board with the structure, which should make it easier to read and navigate: https://miro.com/app/board/o9J_lKpif3E=/?moveToWidget=3074457357166650259&cot=14

This also takes into account @BryceBeagle's proposed re-architecture of the types and in general feels much more organised as a structure.

Note that this is not going to touch public api and imports. The idea is that public imports should be short and memorable

@BryceBeagle feel free to edit this and put more details, I wrote it quickly during a break 😊

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@patrick91 patrick91 added this to the Version 1 milestone Apr 13, 2021
@patrick91 patrick91 added discussion enhancement New feature or request labels Apr 13, 2021
@BryceBeagle BryceBeagle added this to In progress in strawberry Aug 7, 2021
@scratchmex
Copy link
Member

So far the structure seems very nice. I only have one question, why is the core module inside types? Should not be swapped? strawberry.core.types?

@BryceBeagle
Copy link
Member

IIRC, these were supposed to be the "core" types of strawberry. The other things in the strawberry.types directory aren't things that go on the schema and were to be just related to typing (e.g. unset and private). I don't remember why there's both a strawberry.types.scalar and a strawberry.types.core.StrawberryScalar, though. Maybe @patrick91 does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
No open projects
strawberry
In progress
Development

No branches or pull requests

3 participants