New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
st.runtime.get_instance()._session_mgr.list_active_sessions()[0].client.request.protocol
is http on https pages.
#8600
Comments
Hey @wyattscarpenter and thank you for opening this issue! Could you please describe your use case why you need to use protocol in your streamlit app? This probably a issue on interaction with Cloud / Streamlit Open source library, since Streamlit apps there deployed under reverse proxy, so most probably corresponding headers doesn't pass to Streamlit app itself. |
Simply put, I want my app to use the URL on which it is deployed for
various purposes (such as displaying to the end user and for implementing
Google sign-in), and the protocol is part of that url.
…On Mon, May 6, 2024, 2:25 PM Karen Javadyan ***@***.***> wrote:
Hey @wyattscarpenter <https://github.com/wyattscarpenter> and thank you
for opening this issue!
Could you please describe your use case why you need to use protocol in
your streamlit app?
This probably a issue on interaction with Cloud / Streamlit Open source
library, since Streamlit apps there deployed under reverse proxy, so most
probably corresponding headers doesn't pass to Streamlit app itself.
—
Reply to this email directly, view it on GitHub
<#8600 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGQZNEA5CWA5HA3NEEZIQELZA7DKHAVCNFSM6AAAAABHEZD6VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJWGY2TAMJXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @wyattscarpenter, I'm not sure if there's much we can do about this in the Streamlit OS lib side. The issue is most likely because, in a Community Cloud deployment, the connection is indeed an http connection since the TLS connection isn't terminated by the Streamlit server, it's terminated at the load balancer level (and security is maintained by having the network permissions set such that the Streamlit server only accepts traffic from the load balancer in front of it). This would be true of any deployment made where the Streamlit server itself isn't configured to terminate the TLS connection, and while we do have some basic configurability for this included in our config options (see the |
Interesting! Well, fixing this isn't crucial for me, so feel free to deprioritize it, etc. |
Checklist
Summary
st.runtime.get_instance()._session_mgr.list_active_sessions()[0].client.request.protocol
is http on https pages.Reproducible Code Example
Steps To Reproduce
No response
Expected Behavior
Should be https
Current Behavior
Is http
Is this a regression?
Debug info
And also whatever streamlit community cloud uses.
Additional Information
No response
The text was updated successfully, but these errors were encountered: