Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you release v0.8.21? #4612

Open
wonsuc opened this issue Feb 20, 2024 · 14 comments
Open

Can you release v0.8.21? #4612

wonsuc opened this issue Feb 20, 2024 · 14 comments

Comments

@wonsuc
Copy link

wonsuc commented Feb 20, 2024

I mean it's been a so long while since the last version released.
If v0.9.0 takes very very long times more, can you guys release the current develop branch with fixed hotfixes updates?
Sorry if my opinion is not appropriate in the current situation of you guys.

@DennisSuitters
Copy link
Member

We're working on it. I can probably do it, but I'm not sure of the process that @lqez goes through, so unless I'm either given written or verbal permission to do so, I won't be doing it. I have been advocating for it though. If you don't require using Summernote via NPM or CDN, you can build the project locally if you require the latest changes.

@wonsuc
Copy link
Author

wonsuc commented Feb 20, 2024

All libraries of our project need to be managed by npm, that's why.

@sebas-ambrero
Copy link

This blocks updating to 0.8.20 for me as well, the husky fix, PR #4365, is the main issue.

@lqez please help @diemendesign, or give permission :)

@dqwork
Copy link

dqwork commented Apr 4, 2024

Another vote for a patch release here. The husky issue that hasn't been released makes this library unusable if you don't use husky, since it can't be installed with out it

@DennisSuitters
Copy link
Member

It can, I don't use Husky, though, I do use it the Old Skool way which works fine for me.

I'll keep pushing for a release.

@dqwork
Copy link

dqwork commented Apr 4, 2024

I'm not sure what you mean by the old school way.

my package.json contains

"summernote": "^0.8.20",

I run npm ci and it fails with

npm ERR! path <redacted_path>\node_modules\summernote
npm ERR! command failed
npm ERR! command C:\WINDOWS\system32\cmd.exe /d /s /c husky install
npm ERR! 'husky' is not recognized as an internal or external command,
npm ERR! operable program or batch file.

If there is a different way to use this package that doesnt result in this failure (and doesn't require installing husky, please can you share it, it would be appreciated

@DennisSuitters
Copy link
Member

What I was referring to is the traditional way of incorporating Javascript into web pages using <script/> tags.

@dqwork
Copy link

dqwork commented Apr 5, 2024

ah I see, we bundle and pack and all that fun stuff via webpack so I don't thats an option for us, but good to know for others.

Anyway I look forward to the patch release (fingers crossed 😃 )

@DennisSuitters
Copy link
Member

Same, I was hoping it would have happened by now.

@komatom
Copy link

komatom commented Apr 19, 2024

Another vote to release version 0.8.21 with husky fix.

@tsimonq2
Copy link

tsimonq2 commented May 5, 2024

Here is another vote to release a new version; I'm using this for a project I'm developing, and 0.8.20 has a broken Style button with Bootstrap 5. Would be great to rely on a CDN instead of having to vendor this in my code...

@andrii-kasparevych
Copy link

+1, would be nice to have a fresh version released :)

@sebas-ambrero
Copy link

I think @lqez is MIA (for months it looks like) and Dennis does not want to release without approval even though he could.

Not sure what the procedure is when @lqez does not return?

@tsimonq2
Copy link

I really do think there should be a release regardless of @lqez's return - they have not raised any objections, so perhaps their interest has moved on to something else. IMO there are more reasons to release than not release at this point, especially given the bitrot of the most current version.

@DennisSuitters would you reconsider, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants