Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did yarn build on current master repo yesterday to fix youtu.be links not working but now code paste for embed codes do not paste #4639

Open
6 tasks done
azeemh opened this issue May 15, 2024 · 0 comments

Comments

@azeemh
Copy link

azeemh commented May 15, 2024

Checklist

  • I've looked at the documentation to make sure the behavior isn't documented and expected.
  • I'm sure this is an issue with Summernote, not with my app or other dependencies (Angular, Cordova, React, etc.).
  • I've searched through the current issues to make sure this hasn't been reported yet.
  • My issue is pertinent to this repository of Summernote (jQuery), or I was unable to have my issue resolved from the relevant version I'm using, such as Angular, dJango, Rails or React. Please try your issue at the relevent repository first.
  • I understand that issues without interaction for more than 14 days (2 weeks), may be closed at our discretion. We do this, as sometimes issues are abandoned. We may at our discretion, add issues to the relevant project to be looked at, or for maintainers to work through as time permits. This is to help keep issues relevant to the current version of Summernote, and to reduce clutter.
  • I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce

I copied this embed code:

<iframe width="640" height="360" src="https://www.democracynow.org/embed/show/2024/5/15" frameborder="0" allowfullscreen="true"></iframe>

I click on Code View.

I type 2 enters, paste, and put another 2 enters, then put <a>some text</a>.

After clicking Code View again:

The line breaks show up and the "some text" shows up but the code view doesn't accept it.

I tried other pasted information just some text, like an some text here and that works.

However even if I manually type in the iframe it still won't work and the text is removed from the code editor when I go back to see why it failed..

Expected behavior

It should show the embedded iframe like it normally would in 8.1.8

pasting the embed code works fine on the summernote.org homepage editor that has 8.1.8 on it as of today.

Current behavior

Summernote code editor doesn't support iframe embed codes/deletes them.

Minimal example reproducing the issue

No response

Environment

  • Summernote version: build of current master as of 5/14/2024
  • Browser (with version): any firefox or chrome mobile or desktop
  • OS/Platform (with version): linux, windows, android, ios,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant