Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obtainedFrom should be an array #10

Closed
antriver opened this issue May 4, 2020 · 3 comments
Closed

obtainedFrom should be an array #10

antriver opened this issue May 4, 2020 · 3 comments

Comments

@antriver
Copy link
Contributor

antriver commented May 4, 2020

Many of the items can be obtained from multiple sources (see https://animalcrossing.fandom.com/wiki/DIY_recipes/Miscellaneous) so the obtainedFrom property should be an array of strings rather than a single string
@sungyeonu
Copy link
Owner

I just pushed the code, wanna have a look before I close this issue?

@antriver
Copy link
Contributor Author

antriver commented May 4, 2020

@sungyeonu Looks good now!
I was working on a branch to fix loading the "DIY Recipes / Others" page but I see you've fixed that too :)

@sungyeonu
Copy link
Owner

Wonderful. Closing the issue now!

@sungyeonu sungyeonu pinned this issue May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antriver @sungyeonu