Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow additional parameters for sky #48

Open
dsinni opened this issue May 22, 2018 · 0 comments
Open

Enhancement: Allow additional parameters for sky #48

dsinni opened this issue May 22, 2018 · 0 comments

Comments

@dsinni
Copy link

dsinni commented May 22, 2018

I was working on a project not long ago, and I needed the sky to also be visible from the exterior (space), which actually looked great after I used something like the custom code, below:

'''
AFRAME.registerComponent('planet-sky', {

init: function () {

var scene = this.el.sceneEl;
var sky = scene.querySelector('a-sky');

sky.setAttribute('material', 'side', 'double');
sky.setAttribute('theta-length', 180);

}

});
'''

It took some poking around at first to achieve this, so I was thinking it would be great if it were possible to easily set sky parameters such as geometry.thetaLength and material.side for a full sphere that can also be seen from the exterior.

Of course, radius would also be great, which I mentioned in #45.

Just a thought. Keep up the great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant