Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tagSorter and operationSorter options on Docker #6154

Open
tkengo opened this issue Jun 17, 2020 · 3 comments · May be fixed by #8343
Open

tagSorter and operationSorter options on Docker #6154

tkengo opened this issue Jun 17, 2020 · 3 comments · May be fixed by #8343

Comments

@tkengo
Copy link

tkengo commented Jun 17, 2020

Content & configuration

I want to specify tagSorter and operationSorter in a Docker container. But according to the docs here, unfortunately it doesn't support passing tagSorter and operationSorter via environment variable.

スクリーンショット 2020-06-17 19 23 40

スクリーンショット 2020-06-17 19 23 43

Any reasons why these two options are unavailable on Docker? I think we could pass a value as string like 'alpha' / 'method' at least.

Describe the solution you'd like

What I did to solve this is to add tagSorter and operationSorter to the variable list defined in ./docker/configurator/variables.js like this:

+  OPERATION_SORTER: {
+    type: "string",
+    name: "operationsSorter"
+  },
   SHOW_EXTENSIONS: {
     type: "boolean",
     name: "showExtensions"
   },
   SHOW_COMMON_EXTENSIONS: {
     type: "boolean",
     name: "showCommonExtensions"
   },
+  TAG_SORTER: {
+    type: "string",
+    name: "tagsSorter"
+  },

I tested it and It worked well on my local environment, so if it looks good I'll make a PR.

Describe alternatives you've considered

Maybe we could sort at json file beforehand rather than passing sort options to Docker. But it would be still worth if we can pass the options to Docker.

Additional context

@tim-lai
Copy link
Contributor

tim-lai commented Oct 6, 2020

@tkengo At first glance, this looks ok. Please do make a PR!

@dmlyons dmlyons linked a pull request Jan 11, 2023 that will close this issue
11 tasks
@rohitbatta
Copy link

This PR is still open. This is a nice addition to existing configurations, which are not available in docker version.
Could anyone review this PR and help to merge this to master?

@jorenvandeweyer
Copy link

@tim-lai @char0n

Is there still something blocking for this PR to be merged? I'm willing to implement it if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants