Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Wasmer an optional dependency? #177

Open
MaxDesiatov opened this issue Nov 27, 2020 · 3 comments
Open

Make Wasmer an optional dependency? #177

MaxDesiatov opened this issue Nov 27, 2020 · 3 comments
Labels
dependencies Updates to the project dependencies

Comments

@MaxDesiatov
Copy link
Collaborator

After #42 is resolved, we'll be able to run tests in browsers. We should still allow using Wasmer, but I think it's easier to expect that people have a browser installed than Wasmer? Especially as currently it's not as easy to install Wasmer on Apple Silicon via Homebrew. WDYT?

@MaxDesiatov MaxDesiatov added the dependencies Updates to the project dependencies label Nov 27, 2020
@kateinoigakukun
Copy link
Member

I think if we can embed a Wasm runtime in carton, it would be easier to install carton. For example, linking libwasmtime.a.

@syrusakbary
Copy link

syrusakbary commented Nov 30, 2020

Just seen this. Wasmer also should be easily embedded via linking if that's where the needs are (you can find libwasmer.dylib/a in the Wasmer releases).

Note: Wasmer fully supports Apple Silicon (writing this reply from a new M1 macbook, where Wasmer is successfully built and tested). The main reason Wasmer can't yet be installed via brew have nothing to do with Wasmer itself, but mainly because brew itself doesn't yet fully support Big Sur nor Rust. I have hopes they will be able to fix it soon!

@syrusakbary
Copy link

syrusakbary commented Dec 1, 2020

Note: we just discovered a small but on Wasmer when using it on M1 in the latest Rust nightly (via rustup nightly). We are working on fixing it!

Update: the bug is now solved and M1 is fully supported again!

MaxDesiatov added a commit that referenced this issue Dec 25, 2020
This simplifies our CI scripts, and installation via Homebrew and on Linux. It also allows us to pin the version of WASI runtime we use for CLI test execution.

Closes #177.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates to the project dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants