Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A dependency fails to have its resources copied by carton bundle #216

Open
MaxDesiatov opened this issue Jan 24, 2021 · 1 comment
Open
Labels
bug Something isn't working

Comments

@MaxDesiatov
Copy link
Collaborator

A dependency with a resource fails to have its resources copied by carton bundle. I've updated the linked repository to show the problem.

This is the output of carton bundle:

Bundle
├── TopLevelResource.md
├── c78bdf2c8a889c8f.wasm
├── c9143f6becf19317.js
├── index.html
└── swift-wasm-resource-bug_swift-wasm-resource-bug.resources
    └── TopLevelResource.md

I see two potential issues:

  1. TopLevelResource.md appears twice. Once at the root, and once in a resource directory for the module. The specific resource directory seems more correct, as there could be name collisions across modules.
  2. Resource.md from the SubPackageWithResource package is missing entirely.

Originally posted by @fcanas in swiftwasm/swift#2568 (comment)

@MaxDesiatov MaxDesiatov added the bug Something isn't working label Jan 24, 2021
@MaxDesiatov MaxDesiatov changed the title A dependency with a resource fails to have its resources copied by carton bundle. I've updated the linked repository to show the problem A dependency with a resource fails to have its resources copied by carton bundle Jan 28, 2021
@MaxDesiatov MaxDesiatov changed the title A dependency with a resource fails to have its resources copied by carton bundle A dependency fails to have its resources copied by carton bundle Jan 28, 2021
@MaxDesiatov
Copy link
Collaborator Author

A repository for reproduction is available here https://github.com/fcanas/swift-wasm-resource-bug/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant