Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After setting PF to an explicit interface name, shouldn't VFs use it to generate their names accordingly? #32836

Open
wrobelda opened this issue May 15, 2024 · 1 comment
Labels
predictable-ifnames RFE 🎁 Request for Enhancement, i.e. a feature request udev

Comments

@wrobelda
Copy link

wrobelda commented May 15, 2024

systemd version the issue has been seen with

252

Used distribution

Proxmox 8.2.2

Linux kernel version used

6.8.4-2-pve

CPU architectures issue was seen on

x86_64

Component

systemd-udevd

Expected behaviour you didn't see

I have an added an .link file that sets the network interface name explicitly and enables SR-IOV functions:

[Match]
MACAddress=aa:bb:cc:dd:ee:ff

[Link]
Name=lan

[SR-IOV]
VirtualFunction=0
MACAddress=aa:bb:cc:dd:ee:00

The result should be parent interface renamed to lan and VF interfaced created, named after parent interface, i.e. lanv0.

Unexpected behaviour you saw

The parent interface name was changed and an additional VF was created. However, the VF's interface name remained unchanged, in this case enp2s0f1v0. Considering that the interface rename rule is applied first, followed by SR-IOV statement, one would expect that the VF would be consistently named after the renamed parent interface.

At the very least, if this isn't technically feasible, a Name option in [SR-IOV] would also do the job.

Steps to reproduce the problem

Add a .link file that both renames parent interface and adds VFs to it. Notice that while the parent interface name changes, the VF names are generated according to the default systemd predictable naming scheme.

Additional program output to the terminal or log subsystem illustrating the issue

No response

@wrobelda wrobelda added the bug 🐛 Programming errors, that need preferential fixing label May 15, 2024
@wrobelda wrobelda changed the title After renaming parent interface, shouldn't VFs also get renamed accordingly? After setting PF to an explicit interface name, shouldn't VFs use it to generate their names accordingly? May 15, 2024
@github-actions github-actions bot added the udev label May 15, 2024
@yuwata yuwata added RFE 🎁 Request for Enhancement, i.e. a feature request predictable-ifnames and removed bug 🐛 Programming errors, that need preferential fixing labels May 15, 2024
@wrobelda
Copy link
Author

wrobelda commented May 15, 2024

For completeness, I also tested by moving the [SR-IOV] section to a separate file with a name having a higher numeric value, which should get it processed after the parent interface renaming rule:

[Match]
MACAddress=aa:bb:cc:dd:ee:ff

[SR-IOV]
VirtualFunction=0
MACAddress=aa:bb:cc:dd:ee:00

However, the VF interfaces names were still generated using basic systemd schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
predictable-ifnames RFE 🎁 Request for Enhancement, i.e. a feature request udev
Development

No branches or pull requests

2 participants