Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add shadcn as a cli option #1876

Closed
Exotica0122 opened this issue May 9, 2024 · 4 comments
Closed

feat: Add shadcn as a cli option #1876

Exotica0122 opened this issue May 9, 2024 · 4 comments
Labels
🌟 enhancement New feature or request

Comments

@Exotica0122
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Since Theo loves shadcn too it would be nice to have shadcn out of the box. The config should be setup initially when using the cli and the user can add components after using the shadcn cli commands eg: npx shadcn-ui@latest add button after the project setup.

I'd personally use this a lot.

https://www.youtube.com/watch?v=G7lZBKFFnls

Describe the solution you'd like to see

Add shadcn as one of the steps

Describe alternate solutions

N/A

Additional information

No response

@Exotica0122 Exotica0122 added the 🌟 enhancement New feature or request label May 9, 2024
@juliusmarminge
Copy link
Member

Why? You can just run npx shadcn-ui init yourself after.

@afonsopimenta
Copy link
Contributor

afonsopimenta commented May 11, 2024

Why? You can just run npx shadcn-ui init yourself after.

Running npx shadcn-ui init will completly override your tailwind.config.ts file meaning this will be lost:

extend: {
    fontFamily: {
        sans: ["var(--font-geist-sans)", ...fontFamily.sans],
    },
},

You gotta remember to add it back if you're gonna use Geist as your font.
That being said, I dont think it is worth the work just because of this.

@juliusmarminge
Copy link
Member

I have a PR to fix that shadcn-ui/ui#3558

@Exotica0122
Copy link
Contributor Author

Should I close it if it's not worth it?

@juliusmarminge juliusmarminge closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants