-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROCm/hipblas support? #135
Comments
I never even knew whisper.cpp supported that, I'll look into it. |
I only found out myself today, though... I also started looking into it today. It "works on my machine" so if there's any help I can provide just ask! I tried hacking it together myself but gave up, I really need to learn how C/CPP binding crates are made/work so I can be more better. |
If it's as simple as it looks 0392350 should be all it needs. Hopefully it works :3 |
Not quite that simple, it turns out. log output:
relevant parts I think:
|
Try out 31289e2, the hint there was actually super nice, thanks for pointing it out. |
Again fails, but for a... much weirder reason. It tries to install it to
But then running the build again it worked, so I dunno what's up there. Also getting an error trying to run the
Edit: best guess is that there's some difference between latest |
Yeah uh I got nothing for that one. You could cd into sys/whisper.cpp and do a git pull to update whisper.cpp and see if that fixes it. Doesn't look like there's any changes that should affect the repo as it stands so it should compile. |
I did that, got some compile errors.
Seemingly unrelated to the hipblas feature. On ggerganov/whisper.cpp@8f253ef |
Re: #135 (comment) |
Also, did a Full log
Just the stderr
Two things that stand out as weird for me:
I'll be going to sleep so I won't be able to test things for a bit. |
I honestly have no clue with any of this. Besides maybe a search path for clang being missing (although CMake should provide that, not to mention we don't really have control over the arguments there) I can't think of why it wouldn't be searching for it properly. As for the target GPU I have no experience with ROCm at all so I don't even know where to start to set target GPUs. Digging through the upstream CMakeLists.txt doesn't show much of help either, just ROCm libs and nothing specifically related to any target GPU or search paths. |
Well, updating whisper.cpp causes all of these: #135 (comment), meaning I can't build even with As for how to set the target GPU architecture, the Anyways, I patched out those issues in the comment I linked, and it works fine with CPU now even on the updated whisper.cpp. As for ROCm builds, it's still giving me that |
Okay so on the latest commit of It works fine with CPU, but with GPU I get the following chunk of error:
And this error happens with the However! When using Edit: This was only relatively recently added(?) in ggerganov/whisper.cpp#2102 Edit2: So setting
Edit3: Buuut it doesn't work in all cases, strangely. |
Is there any common threads to when it starts failing or is it just random? |
It seems to be during model loading when using it as a library in my own proram (via Which is strange, since loading the model clearly works for the example, so... where could the difference be? I'm even using the same model. |
If you made any changes to build.rs, it's possible there could be some path-dependent things that break when you switch to building outside of the crate directory, which should be fixed. |
The only changes I made aren't path related; adding the Anyways, I can say that right now it... kinda just works? I think the AMDGPU_TARGETS is required for hipblas to work properly, not 100% sure though. E: For my project I just have to figure out how to make it able to know about past speech, but that's for another time, I'm just glad it works right now :> |
Someone else beat me to it, #154 might fix it for you and if it does I can merge that |
I'll give it a shot once I'm able, thanks for letting me know :3 |
Yep, works fine! |
Closed by #154 then :3 |
Since
whisper.cpp
supports ROCm/hipblas, and I plan to use this on an AMD GPU, I'd like to see this project support it too.WHISPER_HIPBLAS=1
makeswhisper.cpp
build with HIPBLAS. It has the following (relevant) build info, which should make the-sys
crate's ability to support it easier to make.I can help with any testing necessary, just give me a commit or a patch to test if you can't, and I'll do it :3
The text was updated successfully, but these errors were encountered: