-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when running sparse Robust PCA #499
Comments
Thanks for reporting this @dawe. @JeanKossaifi, because this skip line is not indented within the if statement above, the sparse tests are always skipped. I assume this should be moved within the if statement? |
Some information I found:
|
Thanks for opening @dawe and thanks for digging into it @aarmey! Regarding the testing, it should only be skipped if sparse is not installed - that should never be an issue for us (we can double check we indeed install pydata-sparse) but avoids test failures if users run the test suite locally without it installed.
We haven't updated the sparse backend for a while and indeed quite likely the interfaces no longer match and should be updated. |
@dawe would you be interested in opening a small PR to fix the issue? |
The same error seems to plague |
Describe the bug
Computation of sparse robust pca crashes as it calls svd with unexpected keyword (
full_matrices
)Steps or Code to Reproduce
Mostly copied from tensorly docs
Expected behavior
Should compute s_RPCA (equal to d_RPCA)
Actual result
Versions
The text was updated successfully, but these errors were encountered: