Add support for closed ATX headers in Markdown output #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
3 tasks
mcdonnnj
force-pushed
the
improvement/support_atx_closed_markdown_headers
branch
from
3271d2f
to
1bc5d6b
Compare
Merged
1 task
Add a new `atx-closed` option to support outputting Markdown documents with closed ATX headers. Signed-off-by: Nicholas McDonnell <50747025+mcdonnnj@users.noreply.github.com>
Update all of the templates for Markdown document output to use the new `atx-closed` option to control whether ATX headers should be open or closed. Signed-off-by: Nicholas McDonnell <50747025+mcdonnnj@users.noreply.github.com>
Update all of the templates for Markdown table output to use the new `atx-closed` option to control whether ATX headers should be open or closed. Signed-off-by: Nicholas McDonnell <50747025+mcdonnnj@users.noreply.github.com>
This adds testing to verify the functionality of the new `atx-closed` option. Signed-off-by: Nicholas McDonnell <50747025+mcdonnnj@users.noreply.github.com>
Ensure the command documentation includes the newly added flag. Signed-off-by: Nicholas McDonnell <50747025+mcdonnnj@users.noreply.github.com>
mcdonnnj
force-pushed
the
improvement/support_atx_closed_markdown_headers
branch
from
1bc5d6b
to
d6d4d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This adds a new
atx-closedoption to support Markdown output with closed ATX headers. The default value isfalseto be consistent with the current output of open ATX headers.Fixes #744
I have:
make test.How has this code been tested
I added tests that are identical to the Markdown Base and Empty Markdown tests but changed the new option to
true. Appropriate golden outputs were added to ensure correct output.