When `container` is `document`, cleanup steps fails with "TypeError: Cannot read properties of null (reading 'removeChild')" #1329

quisido · 2024-05-20T20:05:56Z

Just opening this for tracking with the associated PR: #1330 .

When:

render(<Component />, { container: document });

(Untested: This bug may require that Component render a <body> element.)

Then:

TypeError: Cannot read properties of null (reading 'removeChild')

Because:

// pure.js
    if (container.parentNode === document.body) {
      document.body.removeChild(container);
    }

If we first check that document.body is not null, then this error will not occur.

The text was updated successfully, but these errors were encountered:

MatanBobi · 2024-05-22T08:04:32Z

@quisido Can you please add a reproduction for this? As long as a document exists, JSDOM implicitly creates document.body for you.

quisido · 2024-05-22T08:14:06Z

@quisido Can you please add a reproduction for this? As long as a document exists, JSDOM implicitly creates document.body for you.

Are you unable to reproduce it? I've hit this in two separate projects just by setting container to document.

As far as I'm aware, using container: document in any existing test is the only step required to reproduce this.

MatanBobi · 2024-05-22T08:19:16Z

Two points here:

We do not have the capacity to try and reproduce every issue that's raised in this repo, that's why we ask people who create issues to provide a cloneable reproduction.
When testing layout components was raised here, I created a solution and It doesn't reproduce there: https://stackblitz.com/edit/rtl-template-68mwxh?file=src%2FApp.test.tsx

quisido linked a pull request May 20, 2024 that will close this issue

support document containers in cleanup #1330

Open

4 tasks

Provide feedback