-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetHttpResponseBody with large file #359
Comments
cc @jcchavezs wanna take a look? |
@jcchavezs @mathetake I have updated the issue description, the problem with |
I will check.
…On Tue, 28 Feb 2023, 22:21 RoeiGanor, ***@***.***> wrote:
@jcchavezs <https://github.com/jcchavezs> @mathetake
<https://github.com/mathetake> I have updated the issue description, the
problem with action.ActionContinue is that the
proxywasm.GetHttpResponseBody function call failed after 2 executions.
Let's say the file is big and the OnHttpResponseBody function is called 5
times (like in the last example), the proxywasm.GetHttpResponseBody Is
failed at the third time, which leads us to not being able actually to
collect the whole request body.
—
Reply to this email directly, view it on GitHub
<#359 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXOYAUJPVNGVXKEULM6KF3WZZT6PANCNFSM6AAAAAAVFZBAO4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I am sorry I did not come back before. I also noticed weird behaviours with I will check it soon. |
A lot of time has passed but as far as I remember this was my lab:
|
Hey @jcchavezs ! |
same problem, anything update? |
Describe the bug / error
Issue with the wasm plugin while envoy serving relatively large file (approximately larger than 1mb).
When there is a large file, the request is being drop and the client fail to download the file.
The code is very similar to an example in this repository:
proxy-wasm-go-sdk/examples/http_body/main.go
Line 158 in 4abbb63
Our code:
The issue occurs when the envoy is serving a large file, but the endofstream is never true.
This is a small file (4064 bytes) example:
This is a large file (2698669 bytes) example, the file is being dropped before the
endofstream
result in trueWhen the changing the
types.ActionPause
in!endOfStream
totypes.ActionContinue
, the file is not being dropped:But another issue arise from this case, the
GetHttpResponseBody
being failed after 2 executions, which means you cant really retrieve the whole response body.This is a large file (2698669 bytes) example:
What is your Envoy/Istio version?
envoy version 1.24.0
What is the SDK version?
v0.19.0
What is your TinyGo version?
tinygo version 0.25.0 darwin/amd64 (using go version go1.18.3 and LLVM version 14.0.0)
URL or snippet of your code including Envoy configuration
Additional context (Optional)
The text was updated successfully, but these errors were encountered: