Skip to content
This repository has been archived by the owner on Feb 19, 2021. It is now read-only.

Finish migration to pipenv #661

Open
pitkley opened this issue May 19, 2020 · 1 comment · May be fixed by #662
Open

Finish migration to pipenv #661

pitkley opened this issue May 19, 2020 · 1 comment · May be fixed by #662
Assignees

Comments

@pitkley
Copy link
Member

pitkley commented May 19, 2020

Currently this repository contains both requirements.txt and Pipfile.lock. Those two files are not kept in sync, which means that depending on how a user installs Paperless, they will have a different set of dependencies available than if they had installed using a different method.

To avoid confusion and ensure that our users always use the same set of dependencies, we should move to a single solution. Given the use of Pipenv within CI, removing requirements.txt seems like the sensible option.

(I mainly opened this issue to keep track of this topic myself. I'll work on migrating to Pipenv and will open a PR for this. If there are any opinions or concerns, please feel free to voice them -- either here or on the PR once it exists.)

@pitkley pitkley self-assigned this May 19, 2020
pitkley added a commit to pitkley/paperless that referenced this issue May 19, 2020
In b1e6160 Pipenv was added to
Paperless, adding a note to the changelog in
eec8f09 that a switch to just using
Pipenv was planned.

This commit performs this switch. Having two sources for which
dependencies should be installed (requirements.txt, Pipfile.lock) is
very suboptimal, and the files have diverged since they have been added.

This closes the-paperless-project#661.
@pitkley pitkley linked a pull request May 19, 2020 that will close this issue
@MasterofJOKers
Copy link
Contributor

MasterofJOKers commented May 20, 2020

My own and our official ansible role still use that file: https://github.com/the-paperless-project/ansible-role-paperless/blob/master/tasks/main.yml#L80

EDIT: Might be possible to fix this with pypa/pipenv#363 (comment) or by generating a requirements.txt like this https://github.com/pypa/pipenv/blob/master/docs/advanced.rst#-generating-a-requirementstxt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants