Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default labs where geom when the aesthetic is in both the ggplot and geom_* call #5894

Open
davidhodge931 opened this issue May 20, 2024 · 1 comment · May be fixed by #5879
Open

Default labs where geom when the aesthetic is in both the ggplot and geom_* call #5894

davidhodge931 opened this issue May 20, 2024 · 1 comment · May be fixed by #5879
Labels
visual change 👩‍🎨 Rendering change that will affect look of output

Comments

@davidhodge931
Copy link

davidhodge931 commented May 20, 2024

Default labs are not created based on aesthetics in the geom when the aesthetic is in both the ggplot and geom_* call

library(tidyverse)
library(palmerpenguins)

penguins |> 
  ggplot(aes(x = flipper_length_mm, y = body_mass_g, colour = sex)) +
  geom_point(aes(x = bill_depth_mm, y = bill_length_mm, colour = species))
#> Warning: Removed 2 rows containing missing values or values outside the scale range
#> (`geom_point()`).

Created on 2024-05-20 with reprex v2.1.0

@davidhodge931 davidhodge931 changed the title default labs are not created based on aesthetics in the geom when the aesthetic is in both the ggplot and geom_* call default labs where geom when the aesthetic is in both the ggplot and geom_* call May 20, 2024
@davidhodge931 davidhodge931 changed the title default labs where geom when the aesthetic is in both the ggplot and geom_* call Default labs where geom when the aesthetic is in both the ggplot and geom_* call May 20, 2024
@teunbrand
Copy link
Collaborator

Should be fixed in the label refactoring in #5879.
OTOH, some people might expect the global aesthetics to overrule local aesthetics.

devtools::load_all("~/packages/ggplot2")
#> ℹ Loading ggplot2

palmerpenguins::penguins |> 
  ggplot(aes(x = flipper_length_mm, y = body_mass_g, colour = sex)) +
  geom_point(aes(x = bill_depth_mm, y = bill_length_mm, colour = species))
#> Warning: Removed 2 rows containing missing values or values outside the scale range
#> (`geom_point()`).

Created on 2024-05-20 with reprex v2.1.0

@teunbrand teunbrand linked a pull request May 21, 2024 that will close this issue
@teunbrand teunbrand added the visual change 👩‍🎨 Rendering change that will affect look of output label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visual change 👩‍🎨 Rendering change that will affect look of output
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants